Modular NTT in WHIR v1b#235
Merged
Merged
Conversation
xrvdg
force-pushed
the
xr/integration-v2
branch
from
7cd3328 to
078a039
Compare
Collaborator
|
Given that we want to use the NTT crate from ProveKit repo in WHIR which in turn is being used in provekit-cli crate, I think the changes in |
Bisht13
requested changes
Jan 10, 2026
Collaborator
Author
That would make the NTT crate dependent on WHIR which must not happen. I've moved this to |
Power of two check is now on the individual polynomials
xrvdg
force-pushed
the
xr/integration-v2
branch
from
d574d89 to
99d8d00
Compare
Bisht13
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.