fix: bind evals to transcript [LA - K]#364
Merged
Merged
Conversation
ashpect
changed the title
ashpect
changed the title
ocdbytes
approved these changes
Mar 23, 2026
dcbuild3r
pushed a commit
that referenced
this pull request
May 16, 2026
fix: bind evals to transcript [LA - K]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Evaluation claims (
evals,evals_1,evals_2,public_eval) were sent viaprover_hint_ark, which writes to the hints buffer without absorbing into the Fiat-Shamir sponge. The verifier reads them back without affecting challenge generation. A prover could substitute these values without changing subsequent challenges.Current downstream checks (the WHIR opening verification) happen to reject forged values, but the transcript boundary itself is non-binding for anything sent through the hint channel.
Fix
Replaced all
prover_hint_arkcalls withprover_messagefor evaluation claims in both prover and verifier, so the values are absorbed into the sponge and bound to subsequent Fiat-Shamir challenges.