ci: split monolithic CI into parallel jobs#383
Merged
Conversation
Split the single build_and_test job into separate parallel jobs for fmt, clippy, build+test, and documentation, matching the pattern from upstream whir. This gives faster feedback on failures since lightweight checks (fmt, typos, unused deps) no longer wait behind a full build.
Use --with-metadata flag so machete uses cargo metadata (workspace-aware) instead of filesystem scanning. Fixes false-pass where machete errored on playground/cm31_ntt (not a workspace member) but still exited 0.
- bn254-multiplier: ignore hla and bn254-multiplier-codegen (build.rs deps) - hla: ignore quickcheck (required by quickcheck_macros at expansion time)
veljkovranic
approved these changes
Mar 25, 2026
Collaborator
Author
|
/claude-review |
Code ReviewSummaryThis PR refactors the monolithic ReviewCorrectness & Soundness A few correctness checks:
Code Quality
Testing Suggestions
Verdict✅ Approve — clean, well-motivated CI improvement with no regressions. |
dcbuild3r
pushed a commit
that referenced
this pull request
May 16, 2026
ci: split monolithic CI into parallel jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_and_testCI job into separate parallel jobs: fmt, clippy, build+test, and documentation — matching the upstream whir CI patternnightly-2026-03-04toolchain,moonrepo/setup-rust, concurrency groups, doc tests)Jobs
build_and_testubuntu-24.04-armcargo_clippyubuntu-24.04-armcargo_fmtubuntu-24.04-armcargo_docubuntu-24.04-arm-D warningsunused_depsubuntu-latesttyposubuntu-latestTest plan