Skip to content

Binops integrated#51

Merged
benjaminwilson merged 4 commits into
mainfrom
port-binop-codes
May 22, 2025
Merged

Binops integrated#51
benjaminwilson merged 4 commits into
mainfrom
port-binop-codes

Conversation

@benjaminwilson
Copy link
Copy Markdown
Collaborator

Ryan's work implementing the binary operations AND and XOR has been ported over i.e. made to work with the new witnesses builders.

Also made some changes along the way:

  • constant arguments to a bin op are now folded into the constraints matrix (rather than being injected as witnesses, along with their digital decomposition).
  • the inputs and outputs of the bin op are now combined using a RS fingerprint (rather than using constant multipliers). This means that the inputs and outputs don't need to be range checked.

@benjaminwilson benjaminwilson requested a review from vishady721 May 19, 2025 10:48
@benjaminwilson benjaminwilson marked this pull request as ready for review May 22, 2025 01:13
@benjaminwilson benjaminwilson merged commit c74ff30 into main May 22, 2025
0 of 2 checks passed
dcbuild3r pushed a commit that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant