Skip to content

Fixes file paths#99

Merged
batmendbar merged 4 commits into
mainfrom
fixes-file-paths
May 27, 2025
Merged

Fixes file paths#99
batmendbar merged 4 commits into
mainfrom
fixes-file-paths

Conversation

@batmendbar
Copy link
Copy Markdown
Collaborator

@batmendbar batmendbar commented May 26, 2025

Summary of Changes:

  • Replaced hardcoded noir-r1cs prover witness file path with a CLI variable (was likely a forgotten placeholder).
  • Fixed broken input file paths for the recursive-verifier.
  • Updated the README to reflect these changes.
  • Added nargo execute command to the README .

@batmendbar batmendbar requested review from recmo and vishady721 May 26, 2025 08:41
recmo
recmo approved these changes May 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@recmo recmo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after comments are addressed.

Comment thread README.md Outdated
Comment thread noir-r1cs/src/cli/cmd/generate_gnark_inputs.rs Outdated
Comment thread noir-r1cs/src/cli/cmd/prove.rs
Comment thread noir-r1cs/src/gnark_config.rs Outdated
@batmendbar batmendbar merged commit 8370fb8 into main May 27, 2025
0 of 2 checks passed
@Dzejkop Dzejkop mentioned this pull request May 27, 2025
Closed
@batmendbar batmendbar deleted the fixes-file-paths branch June 23, 2025 08:23
dcbuild3r pushed a commit that referenced this pull request May 16, 2026
@batmendbar
Merge pull request #99 from worldfnd/fixes-file-paths
00ca7c0 
Fixes file paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@recmo recmo recmo approved these changes

@vishady721 vishady721 Awaiting requested review from vishady721

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@batmendbar @recmo