Feat/store draft 1#7
Draft
wouter173 wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store Draft v1
Design
The
mxfx/storetries to solve multiple issues documented inPROBLEMS.md. Specifically, 2) the multiple db implementations (indexeddb, sqlite, memory) and 3) the data model. These problems are being tackled by making use of a repository dependency injection pattern to be exposed to themxfx/clientas well as the client developer.Having a store in a matrix client-server api library means that it can be incredibly well designed and optimised however if not carefully thought out also explode in complexity and unmaintainable design.
Currently, this implementation is incredibly bare bones as it only supports next_batch and room events (timeline and state) to be stored and retrieved. Also, only imperative api's are available as required in the
mxfx/clientbut these will be expanded in the future when data access patterns will become more clear.The following repositories are defined:
The following implementations could be developed as part of mxfx:
@mxfx/store-libsql)@mxfx/store-expo-sqlite)@mxfx/store-indexeddb)Problems