Do not scaffold theme in test

[swissspidy]

One test used wp scaffold _s but http://underscores.me/ is currently down so it fails.

While the site may be up again eventually, there's no reason we need to scaffold a theme for this test, we can just use an existing one. Makes the test more stable.

[github-actions]

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

• composer install: Install dependencies.
• composer test: Run the full test suite.
• composer phpcs: Check for code style violations.
• composer phpcbf: Automatically fix code style violations.
• composer phpunit: Run unit tests.
• composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

[gemini-code-assist]

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability of a test case by modifying how a theme is acquired for testing the distribution archive generation feature. Instead of dynamically scaffolding a new theme from an external source that has proven unreliable, the test now installs a well-known, existing theme. This ensures the test can execute consistently without being affected by external service outages, thereby improving overall test suite stability.

Highlights

• Test Stability Improvement: Replaced the use of wp scaffold _s in a test scenario with wp theme install twentytwelve --force --version=4.7. This change addresses test failures caused by the underscores.me service being intermittently unavailable.
• Reduced External Dependency: The test now relies on installing an existing, stable WordPress theme (twentytwelve) directly, removing the dependency on an external theme scaffolding service and making the test more robust.
• Updated Test Assertions: All subsequent steps in the test scenario, including directory checks, archive creation, and theme installation/deletion, have been updated to reflect the use of the twentytwelve theme and its corresponding archive name.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to improve test stability by removing a dependency on underscores.me. The proposed change to use wp theme install is a good step, but it introduces a new dependency on the WordPress.org theme repository. I've suggested an alternative approach using wp scaffold theme which avoids all external network dependencies, making the test suite even more robust and faster. This change would align better with the goal of creating stable, self-contained tests.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!