-
Notifications
You must be signed in to change notification settings - Fork 23
Add CircleCI 2.1 config. #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| type: string | ||
| default: "latest" | ||
| docker: | ||
| - image: circleci/php:<< parameters.php >>-browsers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever!
|
Looks like a great start already, @FelicianoTech, many thanks for that! A few questions about the current state:
|
I'll make one last push to this PR including the 5.4 image and moving the composer line you mentioned. |
fdc5bcc to
a59af6d
Compare
|
@schlessera Builds for forked pull requests need to be turned on in the CircleCI Settings for this project. |
I've enabled this. |
|
Sorry @danielbachhuber it looks like this was an old project readded so some settings are off. "Enable build processing (preview)" needs to be turned on as well. |
|
No worries, enabled that as well. |
|
I'm merging this as-is for now to be able to play with it outside of a PR. I'll do potential additional fixes in separate PRs. Many thanks for the help with this, @FelicianoTech ! |
Hey,
Here is a first stab at a CircleCI config to test the
doctor-commandrepo.This is using CircleCI v2.1 config syntax and designed to be as close as possible to what's currently happening in the Travis CI builds.
Some immediate differences differences:
Please let me know if there are any questions to what I did, my approach, or how something works.
Also, I was told that the CI process for the command repos seem to more or less be the same. If that's the case, once this config is completed, optimized, and vetted, it could be turned into a CircleCI Orb. This will allow the config to be updated in one location (the orb repo) and can be used in all of the command repos being built on CircleCI. Implementing DRY config.