Skip to content

Update behat-data URLs in tests#612

Draft
swissspidy wants to merge 1 commit intomainfrom
chore/update-tests
Draft

Update behat-data URLs in tests#612
swissspidy wants to merge 1 commit intomainfrom
chore/update-tests

Conversation

@swissspidy
Copy link
Copy Markdown
Member

@swissspidy swissspidy added this to the 2.8.11 milestone Apr 28, 2026
@swissspidy swissspidy added the scope:testing Related to testing label Apr 28, 2026
@github-actions github-actions Bot added bug command:network Related to 'network' command command:option-update Related to 'option update' command labels Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the asset download URLs in the features/site-empty.feature file, migrating them from wp-cli.org to wp-cli.github.io. Feedback was provided to use HTTPS for these URLs to enhance security and to correct the table alignment which was broken by the increased length of the new URLs.

And download:
| path | url |
| {CACHE_DIR}/large-image.jpg | http://wp-cli.org/behat-data/large-image.jpg |
| {CACHE_DIR}/large-image.jpg | http://wp-cli.github.io/behat-data/large-image.jpg |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using https instead of http for the asset URL. GitHub Pages supports HTTPS, which provides better security and avoids potential redirects. Additionally, the table alignment is currently broken because the new URL is longer than the previous one; while the header cannot be modified in this PR, reducing the trailing spaces helps minimize the misalignment.

      | {CACHE_DIR}/large-image.jpg | https://wp-cli.github.io/behat-data/large-image.jpg |

And download:
| path | url |
| {CACHE_DIR}/large-image.jpg | http://wp-cli.org/behat-data/large-image.jpg |
| {CACHE_DIR}/large-image.jpg | http://wp-cli.github.io/behat-data/large-image.jpg |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using https instead of http for the asset URL. GitHub Pages supports HTTPS, which provides better security and avoids potential redirects. Additionally, the table alignment is currently broken because the new URL is longer than the previous one; while the header cannot be modified in this PR, reducing the trailing spaces helps minimize the misalignment.

      | {CACHE_DIR}/large-image.jpg | https://wp-cli.github.io/behat-data/large-image.jpg |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:network Related to 'network' command command:option-update Related to 'option update' command scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant