Update behat-data URLs in tests#612
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request updates the asset download URLs in the features/site-empty.feature file, migrating them from wp-cli.org to wp-cli.github.io. Feedback was provided to use HTTPS for these URLs to enhance security and to correct the table alignment which was broken by the increased length of the new URLs.
| And download: | ||
| | path | url | | ||
| | {CACHE_DIR}/large-image.jpg | http://wp-cli.org/behat-data/large-image.jpg | | ||
| | {CACHE_DIR}/large-image.jpg | http://wp-cli.github.io/behat-data/large-image.jpg | |
There was a problem hiding this comment.
Consider using https instead of http for the asset URL. GitHub Pages supports HTTPS, which provides better security and avoids potential redirects. Additionally, the table alignment is currently broken because the new URL is longer than the previous one; while the header cannot be modified in this PR, reducing the trailing spaces helps minimize the misalignment.
| {CACHE_DIR}/large-image.jpg | https://wp-cli.github.io/behat-data/large-image.jpg |
| And download: | ||
| | path | url | | ||
| | {CACHE_DIR}/large-image.jpg | http://wp-cli.org/behat-data/large-image.jpg | | ||
| | {CACHE_DIR}/large-image.jpg | http://wp-cli.github.io/behat-data/large-image.jpg | |
There was a problem hiding this comment.
Consider using https instead of http for the asset URL. GitHub Pages supports HTTPS, which provides better security and avoids potential redirects. Additionally, the table alignment is currently broken because the new URL is longer than the previous one; while the header cannot be modified in this PR, reducing the trailing spaces helps minimize the misalignment.
| {CACHE_DIR}/large-image.jpg | https://wp-cli.github.io/behat-data/large-image.jpg |
See https://make.wordpress.org/systems/2026/04/23/redirect-request-for-wp-cli-org/