PHPStan improvements

[swissspidy]

No description provided.

[github-actions]

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

• composer install: Install dependencies.
• composer test: Run the full test suite.
• composer phpcs: Check for code style violations.
• composer phpcbf: Automatically fix code style violations.
• composer phpunit: Run unit tests.
• composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

[gemini-code-assist]

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the project's static analysis capabilities by updating a core dependency and refining the PHPStan configuration. It introduces more explicit PHPDoc type hints across various command classes, which helps in catching potential type-related issues earlier and enhances code maintainability. Additionally, it adjusts code quality checks to better accommodate testing utilities.

Highlights

• Dependency Update: The wp-cli/wp-cli dependency has been updated to version ^2.13 in composer.json.
• PHPStan Configuration Improvements: PHPStan configuration has been enhanced by adding tests/phpstan/scan-files.php to scanned files and removing several missingType ignore errors, leading to more precise static analysis.
• PHPDoc Type Hinting: Numerous PHPDoc type hints have been added or refined across several command classes (Core_Language_Command, Plugin_Language_Command, Site_Switch_Language_Command, Theme_Language_Command, CommandWithTranslation, LanguagePackUpgrader) to improve type clarity and static analysis accuracy.
• PHP_CodeSniffer Exclusion: A new exclusion has been added to phpcs.xml.dist to prevent the WordPress.NamingConventions.PrefixAllGlobals sniff from being applied to files within tests/phpstan.
• New PHPStan Scan File: A new file, tests/phpstan/scan-files.php, was introduced to define the WPINC constant, aiding PHPStan in understanding global constants.

Changelog

• composer.json
  • Updated wp-cli/wp-cli dependency to ^2.13.
• phpcs.xml.dist
  • Excluded */tests/phpstan from the WordPress.NamingConventions.PrefixAllGlobals sniff.
• phpstan.neon.dist
  • Added tests/phpstan/scan-files.php to the list of files to be scanned.
  • Removed missingType.iterableValue, missingType.property, and missingType.parameter from ignored errors.
• src/Core_Language_Command.php
  • Added a PHPDoc parameter type hint for the activate_language method.
• src/Plugin_Language_Command.php
  • Added PHPDoc type hints for parameters of the install_one method.
  • Updated PHPDoc type hints for parameters of the install_many method.
  • Refined the return type PHPDoc for the get_all_plugins method.
• src/Site_Switch_Language_Command.php
  • Added PHPDoc type hints for parameters of the __invoke method.
• src/Theme_Language_Command.php
  • Added PHPDoc type hints for parameters of the install_one method.
  • Updated PHPDoc type hints for parameters of the install_many method.
• src/WP_CLI/CommandWithTranslation.php
  • Added PHPDoc type hints for obj_type and obj_fields properties.
  • Added PHPDoc type hints for parameters of the sort_translations_callback method.
  • Corrected PHPDoc type hint for $plugin_data variable.
  • Added PHPStan ignore annotation for argument.type before upgrade method call.
  • Refined the return type PHPDoc for the get_translation_updates method.
  • Refined the PHPDoc type hint for $transient variable.
  • Added a PHPDoc type hint for the $updates variable.
  • Added PHPStan ignore annotation for missingType.iterableValue before get_formatter method.
• src/WP_CLI/LanguagePackUpgrader.php
  • Added PHPStan ignore annotation for missingType.iterableValue before download_package method.
• tests/phpstan/scan-files.php
  • Added a new file to define the WPINC constant.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR tightens PHPStan type-safety across the language command package by replacing broad PHPStan ignore rules with more precise PHPDoc types and a small PHPStan scan bootstrap, aiming to surface real type issues instead of suppressing them globally.

Changes:

• Adds a PHPStan scan file and wires it into phpstan.neon.dist.
• Improves PHPDoc typing for command properties/parameters and various translation-related data structures.
• Replaces global PHPStan ignores with more localized suppressions and bumps the wp-cli/wp-cli dependency constraint.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/phpstan/scan-files.php	Adds a PHPStan-scanned file to define WordPress constants for analysis.
src/WP_CLI/LanguagePackUpgrader.php	Adds a local PHPStan suppression for an untyped iterable parameter.
src/WP_CLI/CommandWithTranslation.php	Adds property/parameter typing and refines translation update typing; introduces localized PHPStan suppressions.
src/Theme_Language_Command.php	Adds more specific PHPDoc types for install subcommand args.
src/Plugin_Language_Command.php	Adds more specific PHPDoc types for install args and plugin list return type.
src/Site_Switch_Language_Command.php	Adds PHPDoc param typing for the invokable command handler.
src/Core_Language_Command.php	Adds a parameter PHPDoc type for a private helper.
phpstan.neon.dist	Adds scan file and removes several global ignore rules.
phpcs.xml.dist	Excludes the new phpstan test directory from the PrefixAllGlobals sniff.
composer.json	Updates wp-cli/wp-cli requirement from ^2.12 to ^2.13.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.