Fixed static variable in class Lexer.#55
Closed
adrigzr wants to merge 5 commits intowp-cli:masterfrom
Closed
Conversation
Member
|
@drakson can you rebase against master and include some tests? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled from https://github.com/wp-cli/php-cli-tools/pull/3, ignore the composer.json.
Static variables are shared between objects. In this case, we dont want this behaviour because each object has his own different properties.
To test it out, just create 2 Lexer objects and try to do 2 foreach with each one. The second object will be bugged in his loop.
This can also be tested calling 'parse' function at least twice in the same runtime.