Skip to content

Fix newly reported PHPStan errors#370

Merged
swissspidy merged 1 commit intomainfrom
fix-phpstan
Feb 13, 2026
Merged

Fix newly reported PHPStan errors#370
swissspidy merged 1 commit intomainfrom
fix-phpstan

Conversation

@swissspidy
Copy link
Member

No description provided.

@swissspidy swissspidy added this to the 2.5.3 milestone Feb 13, 2026
@swissspidy swissspidy requested a review from a team as a code owner February 13, 2026 08:59
Copilot AI review requested due to automatic review settings February 13, 2026 08:59
@swissspidy swissspidy added the scope:testing Related to testing label Feb 13, 2026
@github-actions
Copy link

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link

Summary of Changes

Hello @swissspidy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses newly reported PHPStan errors by updating a core dependency and refining a PHPDoc type hint. These adjustments ensure compatibility with the latest WP-CLI version and enhance the precision of static analysis, contributing to improved code quality and maintainability.

Highlights

  • Dependency Update: The wp-cli/wp-cli dependency in composer.json has been updated from ^2.12 to ^2.13.
  • Type Hint Refinement: A PHPDoc type hint for the $theme parameter in the get_theme_name method within src/Scaffold_Command.php was corrected from string|bool to string|true to improve static analysis accuracy.
Changelog
  • composer.json
    • Updated wp-cli/wp-cli dependency to ^2.13.
  • src/Scaffold_Command.php
    • Corrected PHPDoc type hint for $theme parameter in get_theme_name method from string|bool to string|true.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consists of two changes: an update to the wp-cli/wp-cli dependency and a correction to a PHPDoc type hint in Scaffold_Command.php. The dependency update is a minor version bump. The PHPDoc change from string|bool to string|true for the $theme parameter of the get_theme_name method makes the type hint more specific. My analysis of the call sites confirms the function is never called with false, so this change is correct. Both changes are appropriate and improve the project's maintainability. I have no further suggestions.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes newly reported PHPStan static analysis errors by improving type precision in PHPDoc annotations and updating the wp-cli/wp-cli dependency version.

Changes:

  • Updated PHPDoc type annotation from string|bool to string|true for better type precision
  • Bumped wp-cli/wp-cli requirement from ^2.12 to ^2.13

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Scaffold_Command.php Corrected PHPDoc type annotation for get_theme_name() parameter from `string
composer.json Updated wp-cli/wp-cli dependency from ^2.12 to ^2.13, likely required for improved PHPStan support or stricter type checking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit 5a690ec into main Feb 13, 2026
63 checks passed
@swissspidy swissspidy deleted the fix-phpstan branch February 13, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant