Invalid plugin slug specified with wp scaffold plugin-tests

[Robin-Andrews]

On my Windows 10 machine

wp plugin list gives

+------------------------------------+----------+-----------+---------+
| name                               | status   | update    | version |
+------------------------------------+----------+-----------+---------+
| akismet                            | active   | available | 3.1.10  |
| backupwordpress                    | active   | available | 3.6.1   |
| crafty-social-buttons              | active   | available | 1.5.5   |
| hello                              | inactive | none      | 1.6     |
| one-click-child-theme              | active   | none      | 1.6     |

etc...

yet wp scaffold plugin-tests hello gives Error: Invalid plugin slug specified.

Same for all listed plugins.

Previous to updating from v0.25 this was working.
I also updated psy/psysh

Any suggestions why/how to make work?

[Robin-Andrews]

Also gives same error on creating new plugin scaffolding:

wp scaffold plugin new-plugin

Success: Created plugin files. Error: Invalid plugin slug specified.

[danielbachhuber]

I suspect this is related to #3666

Windows isn't formally supported, but I'm amenable to including a fix if we can figure out what the cause is.

[Robin-Andrews]

That would be great. Like I said, it seems the issue was introduced post v0.25.0

[Rarst]

Also getting a notice in between:

/wp.bat scaffold plugin new-plugin
Success: Created plugin files.
Notice: Undefined index: ci in C:\server\wp-cli\php\commands\scaffold.php on line 568
Error: Invalid plugin slug specified.

Weirdly I only see two instances of this error in source and I can't dump that either of them is responsible for this output. That's weird. Is there anything else that might generate this message indirectly?

[Rarst]

Ok, it seems this is down to check_target_directory() method not normalizing paths:

string(36) "C:/server/www/dev/wp-content/plugins" // WP_PLUGIN_DIR
string(36) "C:\server\www\dev\wp-content\plugins" // $parent_dir

[miya0001]

Ah I wrote the check_target_directory() and I'm sorry for this bug. 😓

I think the problem will be solved if we modify as follows.
But I haven't use WP-CLI on Windows.
Can anyone try it?

https://github.com/wp-cli/scaffold-command/blob/master/src/Scaffold_Command.php#L790-L808

After line 795:

$parent_dir = str_replace( DIRECTORY_SEPARATOR, '/', $parent_dir );

[Rarst]

I promised to do a proper PR, as a resident WordPress Windows person, will get to it... :)

[danielbachhuber]

@Rarst Still up for submitting the PR, or should someone else take care of it?

[Rarst]

Got a little busy, but still intend to this week, :)