Issues 3817 Existing PDF previews not deleted on media regenerate. #3824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbachhuber
requested changes
Feb 21, 2017
features/media-regenerate.feature
Outdated
| | {CACHE_DIR}/large-image.jpg | http://wp-cli.org/behat-data/large-image.jpg | | ||
| | path | url | | ||
| | {CACHE_DIR}/large-image.jpg | http://wp-cli.org/behat-data/large-image.jpg | | ||
| | {CACHE_DIR}/minimal-us-letter.pdf | http://localhost/behat-data/minimal-us-letter.pdf | |
Member
There was a problem hiding this comment.
Can you submit a PR to wp-cli.org with this file? https://github.com/wp-cli/wp-cli.github.com/tree/master/behat-data
Contributor
Author
There was a problem hiding this comment.
O cool, wot a system! Have done that wp-cli/wp-cli.github.com#280
danielbachhuber
approved these changes
Feb 21, 2017
Member
|
Thanks for your work on this, @gitlost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix suggested for issue #3817, passing down the
$fullsizepathfromprocess_regeneration().The behat test requires a test PDF, "minimal-us-letter.pdf", to be uploaded, which I've uploaded to core trac minimal-us-letter.pdf, and temporarily uses "localhost" instead of "wp-cli.org" to run.