Skip to content

Conversation

@cedricrabarijohn
Copy link
Contributor

@cedricrabarijohn cedricrabarijohn commented Mar 24, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Fixes #2081

Related Issue(s):

Testing

Screenshots

Documentation Changes

Dependant PRs

@cedricrabarijohn cedricrabarijohn requested a review from a team as a code owner March 24, 2025 18:53
@headless-platform-by-wp-engine

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: b7420a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@colinmurphy
Copy link
Member

@cedricrabarijohn

Thank you for contributing to Faust 🚀

We will review this PR today.

Can you add a changeset to PR and also fix conflicts for packages/faustwp-core/src/getWordPressProps.tsx . We recently merged in changes for a Next vulnerability so you might need to update your branch.

@colinmurphy
Copy link
Member

@cedricrabarijohn

Sorry can you also sign the CLA too please and confirm in the task description - https://github.com/wpengine/faustjs#contributor-license-agreement

@cedricrabarijohn cedricrabarijohn force-pushed the fix/locale-url-resolution branch from 553a8f0 to 64bedb5 Compare March 26, 2025 09:17
@cedricrabarijohn
Copy link
Contributor Author

Hey @colinmurphy , about the CLA, I've already submitted the form but for some reasons I didn't get any mails from it :(

@colinmurphy
Copy link
Member

Sorry @cedricrabarijohn

As per comment here - #2086 (comment) we are looking into this and we will get back to you as quick as possible. Thank you for your patience and we should have an update tomorrow.

@cedricrabarijohn
Copy link
Contributor Author

ok thank u @colinmurphy !

@colinmurphy colinmurphy merged commit 4ddf732 into wpengine:canary Apr 4, 2025
18 checks passed
@headless-platform-by-wp-engine

Currently, we do not support the creation of preview deployments based on changes coming from forked repositories.
Learn more about preview environments in our documentation.

@colinmurphy
Copy link
Member

@cedricrabarijohn

Thank you ❤️

We will do a release early next week with #2085

@cedricrabarijohn
Copy link
Contributor Author

Thank you @colinmurphy 🚀

@colinmurphy
Copy link
Member

No worries @cedricrabarijohn

We have some security releases too, so we will deploy this in the same release.

Thank you again for contribution 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for URL with Locale Prefix in Headless Next.js Project with WordPress

2 participants