Skip to content

Conversation

@ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Sep 25, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

This pull request focuses on improving RFC 6265 compliance for cookie keys in the @faustwp/core package by sanitizing the URL used in the cookie key. This ensures that the cookie key only contains valid characters, preventing potential issues with cookie handling in browsers.

Cookie key compliance improvements:

Related Issue(s):

Testing

Tested manually with faustwp-getting-started example

Screenshots

Documentation Changes

Dependant PRs

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 7026f8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustwp/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ahuseyn ahuseyn merged commit b5c208f into canary Sep 25, 2025
6 of 16 checks passed
@ahuseyn ahuseyn deleted the fix-cookie-key-2181 branch September 25, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants