fix[faustwp]: (#2311) clean up uploaded blockset zip when extraction fails#2338
Open
latenighthackathon wants to merge 1 commit intowpengine:canaryfrom
Open
fix[faustwp]: (#2311) clean up uploaded blockset zip when extraction fails#2338latenighthackathon wants to merge 1 commit intowpengine:canaryfrom
latenighthackathon wants to merge 1 commit intowpengine:canaryfrom
Conversation
…raction fails When unzip_uploaded_file() returns a WP_Error in process_and_replace_blocks(), the uploaded zip was left behind in the target directory. On repeat failures this accumulates dead files on disk. Delete the target file before returning the error so the upload slot stays clean. Mirrors the existing cleanup_temp_directory() call on the success path. Split out from wpengine#2312 per @josephfusco review feedback — the hash_equals security hardening half stays on that PR so each can be reviewed and reverted independently.
|
Currently, we do not support the creation of preview deployments based on changes coming from forked repositories. |
🦋 Changeset detectedLatest commit: 6295806 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
unzip_uploaded_file()returns aWP_Errorinprocess_and_replace_blocks(), the uploaded.zipstays behind in the target directory. Repeat failures accumulate dead files.This PR deletes the target file before returning the error so the upload slot stays clean. Mirrors the existing
cleanup_temp_directory()call on the success path.Related Issue
Closes #2311
Split out from #2312 per @josephfusco's review feedback — the
hash_equals()security hardening stays on #2312 so each change can be reviewed and reverted independently.Confirm the issue
Confirm the fix
Run the test suite
Checklist
canary@faustwp/wordpress-pluginpatch)