Fix PHP 8 warning on non WP GraphQL post types#812
Merged
Conversation
apmatthews
added a commit
that referenced
this pull request
Mar 17, 2022
apmatthews
added a commit
that referenced
this pull request
Mar 21, 2022
Merged
|
Does this mean that the error will still show? |
Contributor
|
We'll be releasing v0.7.7 of the FaustWP plugin tomorrow with this fix in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Post types that aren't registered with WP GraphQL (like ACF field groups) don't have a
graphql_single_nameproperty. As of PHP 8, accessing undefined properties on objects results in a warning rather than a notice.This fix checks that the
graphql_single_nameproperty exists and is not empty before adding atypeNameto the preview link.Related Issue(s):
Fixes #752
Related: #809
Testing
Unit test case has been added. The test case should fail in the absence of this patch regardless of what PHP version the tests are running on because our test config converts both PHP warnings and notices to exceptions. 🥳