Skip to content

Enabled Python 3.8 Support & Docs#4

Merged
nachomaiz merged 10 commits into
mainfrom
dev-py38-support
Jul 7, 2023
Merged

Enabled Python 3.8 Support & Docs#4
nachomaiz merged 10 commits into
mainfrom
dev-py38-support

Conversation

@nachomaiz
Copy link
Copy Markdown
Contributor

Description

bavapi has been updated to be able to run in Python 3.8.

Python support will now follow PSF release and support schedule. https://devguide.python.org/versions/

Documentation has been refreshed.

Motivation and Context

  • Changed all uses of list, dict, set and type in type hints for Python 3.8-compatible List, Dict, Set and Type.
  • Changed code to avoid updating dictionaries with the union operator |, introduced in Python 3.9.
  • Docstring improvements.

How Has This Been Tested?

The full test suite has been run, as well as mypy and pylint.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread bavapi/jupyter.py
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
Copy link
Copy Markdown
Contributor Author

@nachomaiz nachomaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@nachomaiz nachomaiz merged commit 80cd669 into main Jul 7, 2023
@nachomaiz nachomaiz deleted the dev-py38-support branch July 7, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant