Skip to content

feat: add Stellar announcement range scans#16

Merged
truthixify merged 1 commit into
wraith-protocol:developfrom
kaycke1337:add-stellar-fetch-range
Jun 1, 2026
Merged

feat: add Stellar announcement range scans#16
truthixify merged 1 commit into
wraith-protocol:developfrom
kaycke1337:add-stellar-fetch-range

Conversation

@kaycke1337
Copy link
Copy Markdown

Summary

  • Extend Stellar fetchAnnouncements with ledger/timestamp bounds, cursor resume, and a typed RetentionExceededError
  • Preserve legacy array return when called without range options while returning { announcements, nextCursor } for incremental scans
  • Add unit coverage for explicit ranges, cursor precedence, timestamp conversion, retention errors, and ambiguous bounds
  • Document incremental scanning and update the Stellar scan example

Closes #11

Follow-up

Validation

  • npx prettier --check .
  • npx vitest run
  • npx tsc --noEmit
  • npx tsup
  • git diff --check

Note: local hooks expect pnpm, but pnpm is not available in this shell; the equivalent validation commands above were run with npx.

@truthixify truthixify changed the base branch from main to develop May 27, 2026 17:15
@truthixify
Copy link
Copy Markdown
Contributor

Heads up — we've just set up a develop branch as the integration target for all Drips × Stellar Wave contributions, and I've retargeted this PR's base from main to develop on your behalf. The diff is unchanged; nothing to do on your end.

Going forward, please branch from and target develop. We'll periodically merge developmain as we cut releases. Thanks for contributing!

@truthixify
Copy link
Copy Markdown
Contributor

Clean API design with function overloads preserving the old call shape. RetentionExceededError typed correctly, all 5 acceptance scenarios covered in tests (explicit range, cursor preference, timestamp conversion, retention bound, ambiguous bounds). Merging. Thanks @kaycke1337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stellar fetchAnnouncements time-range filtering

2 participants