Implement specify_fct()#34
Merged
Merged
Conversation
Closes #2.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the specify_fct() function to create factor harmonization specifications. The implementation uses the S7 object system to define a new class hrmn_fct that inherits from factor but serves as a specification object rather than containing actual data.
Key changes:
- Added
specify_fct()function using S7 class system withhrmn_fctclass - Created comprehensive test coverage for the new functionality
- Updated package dependencies to include S7
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| R/specify_fct.R | Implements the main specify_fct() function as an S7 class constructor |
| tests/testthat/test-specify_fct.R | Adds test coverage for class validation and levels storage |
| tests/testthat/test-dummy.R | Removes placeholder test file |
| man/specify_fct.Rd | Auto-generated documentation for the new function |
| R/zzz.R | Adds S7 compatibility for older R versions |
| NAMESPACE | Exports the new function and imports S7 operator |
| DESCRIPTION | Updates version and adds S7 dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.