Skip to content

Implement specify_fct()#34

Merged
jonthegeek merged 1 commit into
mainfrom
fix-2-specify_fct
Oct 3, 2025
Merged

Implement specify_fct()#34
jonthegeek merged 1 commit into
mainfrom
fix-2-specify_fct

Conversation

@jonthegeek
Copy link
Copy Markdown
Collaborator

Closes #2.

@jonthegeek jonthegeek requested a review from Copilot October 3, 2025 12:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the specify_fct() function to create factor harmonization specifications. The implementation uses the S7 object system to define a new class hrmn_fct that inherits from factor but serves as a specification object rather than containing actual data.

Key changes:

  • Added specify_fct() function using S7 class system with hrmn_fct class
  • Created comprehensive test coverage for the new functionality
  • Updated package dependencies to include S7

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
R/specify_fct.R Implements the main specify_fct() function as an S7 class constructor
tests/testthat/test-specify_fct.R Adds test coverage for class validation and levels storage
tests/testthat/test-dummy.R Removes placeholder test file
man/specify_fct.Rd Auto-generated documentation for the new function
R/zzz.R Adds S7 compatibility for older R versions
NAMESPACE Exports the new function and imports S7 operator
DESCRIPTION Updates version and adds S7 dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/specify_fct.R
@jonthegeek jonthegeek enabled auto-merge (squash) October 3, 2025 12:57
@jonthegeek jonthegeek merged commit 58ff92e into main Oct 3, 2025
7 checks passed
@jonthegeek jonthegeek deleted the fix-2-specify_fct branch October 3, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement specify_fct()

2 participants