Implement harmonize_df()#41
Merged
Merged
Conversation
Closes #5.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the harmonize_df() function to harmonize data frames according to specifications, completing issue #5. The implementation includes comprehensive validation, custom harmonization support, and flexible column handling.
Key changes:
- Added core
harmonize_df()function with supporting internal helpers - Refactored function naming conventions to follow
.stop_if_*()pattern - Enhanced specification validation with
.to_hrmn_spec()utility - Updated error class names for consistency
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| R/harmonize_df.R | Core implementation of harmonize_df() and internal helpers |
| R/to_hrmn_spec.R | New specification validation utility functions |
| R/harmonize_fct.R | Updated to use new validation and naming conventions |
| R/specify_df.R | Updated to use renamed validation functions |
| R/aaa-conditions.R | Refactored helper functions with consistent naming |
| tests/testthat/test-harmonize_df.R | Comprehensive test suite for new functionality |
| tests/testthat/test-to_hrmn_spec.R | Tests for specification validation |
| man/*.Rd | Generated documentation for new functions |
| principles.md | Added design principles documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.