Skip to content

Implement harmonize_df()#41

Merged
jonthegeek merged 3 commits into
mainfrom
fix-5-harmonize_df
Oct 10, 2025
Merged

Implement harmonize_df()#41
jonthegeek merged 3 commits into
mainfrom
fix-5-harmonize_df

Conversation

@jonthegeek
Copy link
Copy Markdown
Collaborator

Closes #5.

@jonthegeek jonthegeek requested a review from Copilot October 10, 2025 19:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the harmonize_df() function to harmonize data frames according to specifications, completing issue #5. The implementation includes comprehensive validation, custom harmonization support, and flexible column handling.

Key changes:

  • Added core harmonize_df() function with supporting internal helpers
  • Refactored function naming conventions to follow .stop_if_*() pattern
  • Enhanced specification validation with .to_hrmn_spec() utility
  • Updated error class names for consistency

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
R/harmonize_df.R Core implementation of harmonize_df() and internal helpers
R/to_hrmn_spec.R New specification validation utility functions
R/harmonize_fct.R Updated to use new validation and naming conventions
R/specify_df.R Updated to use renamed validation functions
R/aaa-conditions.R Refactored helper functions with consistent naming
tests/testthat/test-harmonize_df.R Comprehensive test suite for new functionality
tests/testthat/test-to_hrmn_spec.R Tests for specification validation
man/*.Rd Generated documentation for new functions
principles.md Added design principles documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread R/harmonize_df.R Outdated
Comment thread tests/testthat/test-to_hrmn_spec.R Outdated
Comment thread tests/testthat/test-harmonize_fct.R Outdated
jonthegeek and others added 2 commits October 10, 2025 14:27
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jonthegeek jonthegeek enabled auto-merge (squash) October 10, 2025 19:32
@jonthegeek jonthegeek merged commit f136842 into main Oct 10, 2025
7 checks passed
@jonthegeek jonthegeek deleted the fix-5-harmonize_df branch October 10, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement harmonize_df()

2 participants