Summary
As a package developer, in order to ensure object stability, I would like to receive an error if I pass unused dots with most arguments.
Details
Moreso than with other functions in stbl, it is conceivable that users will pass ... erroneously to to_lst(). as.list() silently discards dots in most (all?) cases. Implement explicit to_lst() methods for classes that will definitely discard ..., and use rlang::check_dots_empty0(..., call = call) to ensure that the dots are empty. We need to explicitly include x_arg and call args in these methods, so those don't get passed as dots. The default method can still pass dots, in case a method is implemented outside base that will actually use the dots.
The same issue exists for to_df().
Summary
Details
Moreso than with other functions in stbl, it is conceivable that users will pass
...erroneously toto_lst().as.list()silently discards dots in most (all?) cases. Implement explicitto_lst()methods for classes that will definitely discard..., and userlang::check_dots_empty0(..., call = call)to ensure that the dots are empty. We need to explicitly includex_argandcallargs in these methods, so those don't get passed as dots. The default method can still pass dots, in case a method is implemented outside base that will actually use the dots.The same issue exists for
to_df().