Separate Condition Messages from Signal

[jonthegeek]

Errors don't have to be super fast; they'll stop before repeating, so the time won't build up. Focus on making them complete. Collect messages about all possible errors, THEN signal the condition.

[jonthegeek]

I don't want to implement this, at least not how I was thinking here.

[jonthegeek]

Rationale for not doing it: Erroring doesn't have to be fast, but getting through the checks should be. I intentionally code this with a sort of "stop if you fail, return the good thing if you don't" philosophy; I'd have to deal with the returns everywhere to see if they have an error in them, and that would get slow and messy.

[jonthegeek]

Re-consider this specifically for better compatibility with S7. S7 validation should return a character vector with all the reasons for failure, as a sort of incomplete sentence. It might be possible to use withCallingHandlers() in a wrapper in order to collect all the would-be error messages (although I think "downstream" steps might fail in unexpected ways if we plow through errors, so I'm not sure).

It might also make sense to make specific versions of stabilize_*() and to_*() that are focused on this. Maybe validate_*() since they'd specifically be used within (S7) validation.