Skip to content

feat(core): ✨ made CoreContactLink component#422

Merged
techoneel merged 6 commits intodevelopmentfrom
WRPD-enhancement-421
Nov 21, 2024
Merged

feat(core): ✨ made CoreContactLink component#422
techoneel merged 6 commits intodevelopmentfrom
WRPD-enhancement-421

Conversation

@PritamBag
Copy link
Copy Markdown
Contributor

Description

Created a new CoreContactLink component to handle various contact types (email, phone, SMS, etc.).

  • Refactored CorePhoneLink and CoreEmailLink to utilize CoreContactLink internally.
  • Reduced code duplication and improved reusability for contact-related components.
  • Added support for configurable props such as variant, icon, and contact.

Ref: #421

Related Issues

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers


Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

unify CorePhoneLink and CoreEmailLink using CoreContactLink for reusability

Ref: #421
@PritamBag PritamBag added the enhancement New feature or request label Nov 18, 2024
@PritamBag PritamBag requested a review from techoneel November 18, 2024 07:04
@PritamBag PritamBag self-assigned this Nov 18, 2024
@PritamBag PritamBag linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@techoneel techoneel merged commit 66d12c8 into development Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enhancement: make CoreContactLink component

2 participants