fix(core): 🐛 fix jarring effect#438
Merged
anantakumarghosh merged 2 commits intodevelopmentfrom Feb 11, 2025
Merged
Conversation
Fixed jarring content shift in AppContainerLayout when CoreRequestProgressBar visibility toggles, ensuring smooth transitions. Ref #437
fix z index of request progress bar and so on for fix overlap of that with profile card Ref #437
anantakumarghosh
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In AppContainerLayout, the CoreRequestProgressBar is used. The issue occurs when the CoreRequestProgressBar is displayed, causing the content of this layout to shift downward. When CoreRequestProgressBar is hidden, the content moves back up, creating a jarring effect. I fixed this bug.
Related Issues
Ref #437
Testing
Checklist
Screenshots (if applicable)
Additional Notes
Reviewers
Maintainer Notes