Skip to content

feat(global): ✨ itemGridProps and itemItemProps props has been added to corelist#138

Merged
techoneel merged 6 commits intodevelopmentfrom
WRPD-feature-136
Oct 14, 2024
Merged

feat(global): ✨ itemGridProps and itemItemProps props has been added to corelist#138
techoneel merged 6 commits intodevelopmentfrom
WRPD-feature-136

Conversation

@arkaprota
Copy link
Copy Markdown
Member

Description

  • borderlist has been added border in the subcomponent of the corelist

  • changes in the gridItemComponent props

Ref: #136

Related Issues

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Screenshot 2024-09-21 142715

Additional Notes

Reviewers


Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

borderlist has been added border in the subcomponent of the corelist

Ref: #136
@arkaprota arkaprota requested a review from techoneel September 21, 2024 09:01
@arkaprota arkaprota self-assigned this Sep 21, 2024
@arkaprota arkaprota added enhancement New feature or request requirement-proposed This is a new proposed feature labels Sep 21, 2024
@arkaprota arkaprota requested a review from samhere17 September 21, 2024 09:01
@arkaprota arkaprota linked an issue Sep 21, 2024 that may be closed by this pull request
arkaprota and others added 4 commits September 21, 2024 20:01
the code structure has been improved in corelist

Ref: #136
added constants and add a new props itemStylesProps to add styleClasses in the child of CoreList

Ref: #136
@arkaprota arkaprota changed the title feat(global): ✨ borderList props has been added to corelist feat(global): ✨ itemGridProps and itemItemProps props has been added to corelist Sep 23, 2024
@arkaprota
Copy link
Copy Markdown
Member Author

the name of the props has changed and the code has a changed to new format

@arkaprota arkaprota assigned techoneel and unassigned arkaprota Oct 14, 2024
Copy link
Copy Markdown
Member

@techoneel techoneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go

@techoneel techoneel merged commit 2e127ab into development Oct 14, 2024
@arkaprota arkaprota assigned arkaprota and unassigned techoneel Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request requirement-proposed This is a new proposed feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: enablement of grid view mode in NativeList

2 participants