Conversation
Member
Author
|
Any opinions on how removing variable contained within constants should behave? Options are:
|
Contributor
|
If I understand constants correctly, they are not as fundamental to the data object as axes are, so I don't think an error is necessary. Nonetheless, I can imagine users removing these variables inadvertently. Perhaps allow users to remove, but raise a warning? |
Member
|
I agree with @p770193 - a visible warning seems appropriate |
Member
Author
|
Any opinions on how Join should handle constants? (Need to merge from master to make those changes if any are required) While I haven't tested, I think join would currently inherit constants from the first data's attrs.
|
untzag
approved these changes
Sep 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #734
To do:
Add constants in relevant from methods (perhaps to be broken up into separate PRs for each)No longer planning on adding constants in from_methods, those will come when they are useful/have good heuristics for what to add.