Swap migrated reads to Go RPC#16
Conversation
|
Droid finished @jonathanhaaswriter's task —— View job Validated 1 candidate and approved a single P1 comment: this PR removes the web client's REST fallback before Connect is part of the default setup. That creates a real regression for core read-only screens in environments still running only the existing Express API. |
| return aperioConnectClient.getDashboardMetrics(); | ||
| } | ||
| return request<{ data: DashboardMetrics }>("/api/v1/dashboard/metrics"); | ||
| return aperioConnectClient.getDashboardMetrics(); |
There was a problem hiding this comment.
[P1] Restore the REST fallback when Connect is not configured
This PR removes the NEXT_PUBLIC_CONNECT_API_BASE_URL guard from multiple migrated read helpers even though Go RPC is still opt-in in this repo: README.md documents setting that env var explicitly, .env.example leaves it blank, and apps/web/next.config.mjs does not proxy /aperio.v1.AperioService/*. In the default setup those dashboard/findings/apps/connectors/SIEM/shadow-IT reads now go to missing Connect endpoints (same-origin /aperio.v1... when the var is blank, or http://localhost:4100 when it is unset) instead of falling back to the existing REST API, so those screens stop loading unless the Go service is separately configured.
Summary
Validation