fix(policy): recompile CEL programs on rollback#141
Open
jonathanhaaswriter wants to merge 3 commits intomainfrom
Open
fix(policy): recompile CEL programs on rollback#141jonathanhaaswriter wants to merge 3 commits intomainfrom
jonathanhaaswriter wants to merge 3 commits intomainfrom
Conversation
josh-writer
requested changes
Mar 25, 2026
RollbackPolicy called syncConditionProgramsLocked which deletes the compiled program cache before recompiling. If recompilation of the historical version failed, the active policy was left with no compiled CEL programs, causing evaluations to silently stop matching. Save the current CEL programs before sync and restore them if recompilation fails, so a failed rollback never corrupts the active policy's evaluation state. Add test verifying that a failed rollback to an invalid CEL version preserves the current policy's compiled programs.
jonathanhaaswriter
force-pushed
the
fix/policy-rollback-cel-sync
branch
from
2774b97 to
ea8c658
Compare
Collaborator
Author
|
Re-reviewed the current diff and I don't have any additional actionable findings right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing