Skip to content

Conversation

@UladzislauK-Writer
Copy link
Collaborator

@UladzislauK-Writer UladzislauK-Writer commented Nov 24, 2025

Summary by CodeRabbit

  • Chores
    • Enhanced the package verification mechanism in the automated release pipeline to provide more accurate confirmation that newly published versions are properly available to users before marking the release as complete. This improvement strengthens the overall reliability and accuracy of the release process and helps ensure successful package distribution.

✏️ Tip: You can customize this high-level summary in your review settings.

@UladzislauK-Writer UladzislauK-Writer merged commit bc7c799 into dev Nov 24, 2025
13 of 15 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The wait-for-pypi job in the publish workflow was modified to perform actual installation checks instead of simulated ones. The --dry-run flag was removed from the until condition, while retry and timeout logic remain unchanged.

Changes

Cohort / File(s) Summary
GitHub Actions publish workflow
\.github/workflows/publish\.yml
Removed --dry-run flag from the wait-for-pypi until condition to perform real package installation verification instead of dry-run simulation

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that the real installation check succeeds reliably when the package is available on PyPI
  • Confirm retry/timeout values are appropriate for actual installation operations

Possibly related PRs

Poem

🐰 No more pretend, we're for real now,
Installing packages, taking a bow,
The --dry-run flag bids adieu,
Workflows now test what's genuinely true!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vlad/wait-for-pypi

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1cc71dc and 8bbeb16.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@UladzislauK-Writer UladzislauK-Writer deleted the vlad/wait-for-pypi branch November 24, 2025 11:23
This was referenced Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants