chore(ui): move JsonViewer in shared components - WF-98
#610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madeindjs
force-pushed
the
WF-98
branch
4 times, most recently
from
ae75072 to
2dcbc2c
Compare
The `BaseJsonViewer` needs to be reused in workflow module, which make it harder to reuse since we have a clear separation of components used in Editor and those used in Renderer. So we have to introduce a new kind of `shared` components that can be reused in both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BaseJsonViewerneeds to be reused in workflow module, which make it harder to reuse since we have a clear separation of components used in Editor and those used in Renderer.So we have to introduce a new kind of
sharedcomponents that can be reused in both.