-
Notifications
You must be signed in to change notification settings - Fork 97
Autogen loader #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autogen loader #802
Conversation
| .rotating-circle.center { | ||
| animation: rotateClockwise 16s linear infinite; | ||
| top: -50%; | ||
| left: 17%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hear me out. For some reason, that I couldn't find yet, this little dude ignored all the translates and I couldn't center it that way. No clue why for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's because you use custom-class to apply the class in the children, but .left is defined in the parent , and the style is scoped.
Using class as I suggested, and moving all the styles in the parent instead might solve your issue.
| <RotatingCircle custom-class="rotating-circle left" /> |
|
Looks great, now we have to bring it in... @polymorpheuz can we make it pass CI? I see it's blocked by Prettier. Or if you want we can clean it up and take it from here. |
|
@ramedina86 Oh, sorry. Fixed this guy now! |
madeindjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but good job 💪
Description
Basically, added the autogen loader :D
Screen.Recording.2025-04-01.at.11.39.14.AM.mov