Skip to content

Conversation

@samchon
Copy link
Member

@samchon samchon commented Nov 13, 2025

This pull request makes substantial improvements to the Prisma Schema Review system prompt and updates related code to enhance clarity, enforce mandatory function calls, and improve output structure. The changes provide clearer instructions for agents, reorganize review dimensions, and ensure that outputs are structured and actionable.

Prompt and Review System Improvements:

  • Major rewrite and reorganization of PRISMA_REVIEW.md:
    • Clarified agent mission, execution strategy, and mandatory function call requirements.
    • Reorganized input materials, review dimensions, and process steps for greater clarity.
    • Expanded and grouped review dimensions (now 14 total), with explicit descriptions and examples for each.
    • Provided detailed output requirements including field descriptions, output format, and a checklist to ensure completeness and compliance.
    • Added explicit requirement to call the process() function with the correct payload, making this step mandatory and the primary purpose of the agent. [1] [2]

Codebase Enhancements:

  • Improved import structure in transformPreliminaryHistory.ts:
    • Added writePrismaApplication to imports for future use or clarity.
  • Improved assistant message creation:
    • Changed assistant message content to use toJsonBlock(oldbie) for better formatting and structure.

These changes collectively ensure that the Prisma Schema Review process is systematic, thorough, and produces actionable outputs, with clear requirements for agents and improved code maintainability.

@samchon samchon requested a review from Copilot November 13, 2025 08:48
@samchon samchon self-assigned this Nov 13, 2025
@samchon samchon added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 13, 2025
@samchon samchon added this to WrtnLabs Nov 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the Prisma Schema Review system with substantial improvements to system prompts, code structure, and agent orchestration patterns. The changes introduce a mandatory function-calling approach with clearer execution strategies and reorganize code for better maintainability.

Key Changes

  • System Prompt Rewrite: Comprehensive reorganization of PRISMA_SCHEMA.md, PRISMA_REVIEW.md, and PRISMA_CORRECT.md with explicit function call requirements, clearer review dimensions (14 total), and detailed execution checklists
  • Preliminary Request Pattern: Introduction of unified preliminary data request handling across Prisma agents with type discriminators for request routing
  • Code Organization: Refactored imports in packages/utils and moved writePrismaApplication to shared utils package for better reusability

Reviewed Changes

Copilot reviewed 33 out of 34 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/rag.bash Updated archive commands to change --from parameter from "interface" to "prisma" for all test scenarios
pnpm-lock.yaml Dependency updates including @types/node version bump and rolldown package version updates
packages/utils/src/prisma/writePrismaApplication.ts Refactored imports to use relative paths for ArrayUtil, MapUtil, and StringUtil
packages/utils/src/prisma/index.ts New export file for prisma utilities
packages/utils/src/index.ts Added exports for prisma utilities and ArrayUtil
packages/utils/src/ArrayUtil.ts New utility file with asyncMap and paddle functions
packages/utils/package.json Added @types/node devDependency
packages/compiler/src/prisma/AutoBePrismaCompiler.ts Updated import to use writePrismaApplication from @autobe/utils
packages/agent/src/orchestrate/prisma/structures/*.ts Added request type discriminators and preliminary request patterns to IProps interfaces
packages/agent/src/orchestrate/prisma/orchestrate*.ts Introduced AutoBePreliminaryController integration with unified request handling
packages/agent/src/orchestrate/prisma/histories/*.ts Renamed history transformation functions (removed plural "Histories" suffix) and integrated preliminary controller
packages/agent/src/orchestrate/interface/*.ts Removed unnecessary type casts (as any) from preliminary validation calls
packages/agent/src/orchestrate/common/histories/transformPreliminaryHistory.ts Enhanced assistant messages with toJsonBlock formatting and added Prisma schema file output
packages/agent/prompts/PRISMA_*.md Major restructuring with explicit function call requirements, execution strategies, and comprehensive review dimensions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samchon samchon marked this pull request as ready for review November 13, 2025 09:39
@samchon samchon merged commit 241b547 into main Nov 13, 2025
4 checks passed
@samchon samchon deleted the feat/rag-prisma branch November 13, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants