Fix nil-vs-empty-array inconsistency in buildEventChannelResourceForWebBroker policy lists

[coderabbitai]

Summary

In gateway/gateway-controller/pkg/policyxds/event_channel_translator.go, the buildEventChannelResourceForWebBroker function initializes API-level and channel-level policy slices (apiOnConnectionInit, apiOnProduce, apiOnConsume, and their channel-level equivalents) as nil rather than empty slices ([]interface{}{}). When no policies are configured, these nil slices are serialized as null in the EventChannelConfig xDS resource, whereas the equivalent WebSub translator (buildEventChannelResourceForWebSub) correctly emits empty arrays for the same case.

This inconsistency in the wire format can cause unexpected behavior in the event gateway runtime when it parses policies.on_connection_init, policies.on_produce, and policies.on_consume fields.

Fix

Initialize the policy slice variables to empty slices instead of nil:

// API-level
apiOnConnectionInit := []interface{}{}
apiOnProduce := []interface{}{}
apiOnConsume := []interface{}{}

// Channel-level (inside the channels loop)
channelOnConnectionInit := []interface{}{}
channelOnProduce := []interface{}{}
channelOnConsume := []interface{}{}

References

• PR introducing the issue: Add implementation for WebBrokerAPIs #1954 (review comment: Add implementation for WebBrokerAPIs #1954 (comment))
• Related discussion: [DO NOT MERGE] Add Implementation for Exposing Brokers as Subscribable APIs over Web-friendly Protocols #1944

Requested by @senthuran16.