Fix Build & push event-gateway-controller to temp registry#2224
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWorkflow Build Step AlignmentUpdated the "Build & push event-gateway-controller to temp registry" step in the jfrog-scan workflow to use the project's shared Make target instead of an inline docker buildx command. What changed:
Why: Impact: WalkthroughThe JFrog scan workflow's step for building and pushing the Suggested Reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Fix
Replace the raw
docker buildx buildcommand withmake -C gateway/gateway-controller build-and-push-multiarch, matching the pattern used by every other step in this workflow. The Makefile already passes all required build contexts (policies,target,sdk,sdk-core,common,build-manifest) correctly.The
policiesdirectory (gateway/target/build/gateway-controller/policies) is populated by the gateway-runtime step that runs earlier in the workflow via itsextract-policiestarget.Commit 0f8b59a (
refactor(gateway): source policy defs from gateway-builder output) changed the Dockerfile to replace the checked-indefault-policies/folder with aCOPY --from=policies . /app/default-policiesbuild context. This was added to the Makefile'sbuild-and-push-multiarchcorrectly, but thejfrog-scan.yamlstep was not updated.