Skip to content

Fix: Add httpPost connection configuration information for Asgardeo (Product IS issue #27621)#6079

Merged
pavinduLakshan merged 5 commits into
masterfrom
fixing-product-is-issue-27621-1776691959
Apr 21, 2026
Merged

Fix: Add httpPost connection configuration information for Asgardeo (Product IS issue #27621)#6079
pavinduLakshan merged 5 commits into
masterfrom
fixing-product-is-issue-27621-1776691959

Conversation

@wso2-engineering-bot
Copy link
Copy Markdown

This PR was automatically generated by Claude AI.

  • Fixes [Asgardeo] httpPost request connection configuration information is missing product-is#27621
  • Type: Documentation
  • Summary: Added connection configuration information (connection timeout, read timeout, connection request timeout, and retry count) for the httpPost function in Asgardeo documentation. The information is presented without deployment.toml references since Asgardeo is a SaaS platform.
  • Affected Versions: Asgardeo (SaaS platform - single version)
  • Style Scope Verification: Microsoft Style Guidelines have been applied ONLY to newly added content without modifying existing content style.
  • Verification: mkdocs build --strict passed successfully

Changes Made

Added a conditional note section in the httpPost function documentation that displays only for Asgardeo. The note includes a table with the following default connection configurations:

  • Connection timeout: 2000 ms
  • Read (socket) timeout: 3000 ms
  • Connection request timeout: 2000 ms
  • Retry count: 2

The implementation uses Jinja templating ({% if product_name == "Asgardeo" %}) to ensure this information only appears in Asgardeo documentation and not in WSO2 Identity Server documentation.

…product-is#27621)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@pavinduLakshan has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 37 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 50 minutes and 37 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: ac5007cf-0319-406c-ba4e-7c733b2d2370

📥 Commits

Reviewing files that changed from the base of the PR and between e070dbd and 450c412.

📒 Files selected for processing (1)
  • en/includes/references/conditional-auth/api-reference.md
📝 Walkthrough

Walkthrough

Added an Asgardeo-only note to the httpPost API section documenting default connection configuration values (connection timeout, read/socket timeout, connection request timeout, and retry count) without referencing deployment.toml.

Changes

Cohort / File(s) Summary
Asgardeo Documentation - HTTP Post Configuration
en/includes/references/conditional-auth/api-reference.md
Inserted an Asgardeo-only note after the httpPost section containing a table of default connection configuration values: connection timeout = 2000 ms, read/socket timeout = 3000 ms, connection request timeout = 2000 ms, retry count = 2. Also added <!-- markdownlint-disable-file MD007 --> at file top.

Suggested labels

Team/Authentication & registration

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding httpPost connection configuration information for Asgardeo, with direct reference to the related issue.
Description check ✅ Passed The PR description adequately explains the purpose, changes, and verification, though it deviates from the repository's template structure and doesn't include the security checks section.
Linked Issues check ✅ Passed The PR successfully addresses all requirements from issue #27621: documents the four specified default connection configuration values for httpPost in Asgardeo, presents them without deployment.toml references, and uses conditional templating for Asgardeo-specific content.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue. The markdownlint directive and conditional note for httpPost configuration are within scope; no extraneous modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixing-product-is-issue-27621-1776691959

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
en/includes/references/conditional-auth/api-reference.md (1)

7-7: ⚠️ Potential issue | 🟠 Major

Fix markdownlint blocker: nested list indentation at Line 7.

CI is failing with MD007/ul-indent at Line 7, so this PR cannot merge until that indentation is adjusted to the lint rule expected in this file.

Proposed fix
-    - [`onLoginRequest()`](`#initial-login-request`)
+  - [`onLoginRequest()`](`#initial-login-request`)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@en/includes/references/conditional-auth/api-reference.md` at line 7, The
markdownlint error MD007/ul-indent is caused by the nested list item "-
[`onLoginRequest()`](`#initial-login-request`)" having incorrect indentation; fix
it by indenting this nested list entry under its parent list level (use the
project's preferred nest indent, typically two spaces) so the `onLoginRequest()`
link aligns as a child list item and satisfies the UL indentation rule.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@en/includes/references/conditional-auth/api-reference.md`:
- Line 7: The markdownlint error MD007/ul-indent is caused by the nested list
item "- [`onLoginRequest()`](`#initial-login-request`)" having incorrect
indentation; fix it by indenting this nested list entry under its parent list
level (use the project's preferred nest indent, typically two spaces) so the
`onLoginRequest()` link aligns as a child list item and satisfies the UL
indentation rule.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 0c2f2f14-d1c8-44a8-9ae7-10699701f5e4

📥 Commits

Reviewing files that changed from the base of the PR and between e76ce43 and 3846c86.

📒 Files selected for processing (1)
  • en/includes/references/conditional-auth/api-reference.md

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pavinduLakshan
❌ wso2-engineering-bot


wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

pamodaaw
pamodaaw previously approved these changes Apr 21, 2026
Comment thread en/includes/references/conditional-auth/api-reference.md Outdated
Comment thread en/includes/references/conditional-auth/api-reference.md Outdated
pamodaaw
pamodaaw previously approved these changes Apr 21, 2026
Comment thread en/includes/references/conditional-auth/api-reference.md Outdated
@pavinduLakshan pavinduLakshan merged commit b038300 into master Apr 21, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Asgardeo] httpPost request connection configuration information is missing

5 participants