Skip to content

feat: add image.tag support and make tag/digest optional in deployment templates#191

Merged
kavindasr merged 7 commits intomainfrom
copilot/update-image-digest-logic
Apr 10, 2026
Merged

feat: add image.tag support and make tag/digest optional in deployment templates#191
kavindasr merged 7 commits intomainfrom
copilot/update-image-digest-logic

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

  • Explore repository structure and find all deployment files with image digest pattern
  • Update all-in-one/templates/am/instance-1/wso2am-deployment.yaml
  • Update all-in-one/templates/am/instance-2/wso2am-deployment.yaml
  • Update distributed/control-plane/templates/control-plane/instance-1/wso2am-cp-deployment.yaml
  • Update distributed/control-plane/templates/control-plane/instance-2/wso2am-cp-deployment.yaml
  • Update distributed/gateway/templates/gateway/wso2am-gateway-deployment.yaml
  • Update distributed/key-manager/templates/key-manager/wso2am-km-deployment.yaml
  • Update distributed/traffic-manager/templates/traffic-manager/instance-1/wso2am-tm-deployment.yaml
  • Update distributed/traffic-manager/templates/traffic-manager/instance-2/wso2am-tm-deployment.yaml
  • Add image.tag field to all deployment templates (per PR feedback)
  • Add tag field to all values.yaml files (all-in-one and 4 distributed charts)
  • Update docs default_values.yaml files (14 files across 6 pattern folders)
  • Fix: make image.tag conditional to prevent invalid image references
  • Revert README updates from helm-docs
  • Change image logic to if-else-if pattern (digest > tag > none)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 9, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kavindasr
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@kavindasr kavindasr marked this pull request as ready for review April 9, 2026 05:26
RakhithaRR
RakhithaRR previously approved these changes Apr 9, 2026
@kavindasr
Copy link
Copy Markdown
Contributor

@copilot add .Values.wso2.deployment.image.tag to the image:. It should look like this:

image: {{ .Values.wso2.deployment.image.registry }}/{{ .Values.wso2.deployment.image.repository }}:{{} .Values.wso2.deployment.image.tag }{{- if .Values.wso2.deployment.image.digest }}@{{ .Values.wso2.deployment.image.digest }}{{- end }}

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 9, 2026

@copilot add .Values.wso2.deployment.image.tag to the image:. It should look like this:

image: {{ .Values.wso2.deployment.image.registry }}/{{ .Values.wso2.deployment.image.repository }}:{{}...

Added .Values.wso2.deployment.image.tag to the image reference in all 8 deployment templates with conditional logic. Also added the tag field to all 5 values.yaml files and updated all 14 docs default_values.yaml files across the 6 pattern folders. (d04deec)

Copilot AI changed the title feat: make image.digest optional in deployment templates feat: add image.tag support and make tag/digest optional in deployment templates Apr 9, 2026
Copilot AI requested a review from kavindasr April 9, 2026 05:55
@kavindasr
Copy link
Copy Markdown
Contributor

@copilot use helm-docs and update the readme files

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 9, 2026

@copilot use helm-docs and update the readme files

Updated all 5 README files using helm-docs v1.14.2 to include the new image.tag field documentation. (8db8be2)

Agent-Logs-Url: https://github.com/wso2/helm-apim/sessions/269c948d-d1c6-4f5d-b9b0-921e4e76445b

Co-authored-by: kavindasr <59206135+kavindasr@users.noreply.github.com>
@kavindasr kavindasr merged commit e8393a7 into main Apr 10, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants