Skip to content

Comments

[BI & MI Data Mappers] Fix positioning mapping options widget for root input,output mappings#511

Merged
axewilledge merged 3 commits intowso2:mainfrom
madushajg:idm
Sep 19, 2025
Merged

[BI & MI Data Mappers] Fix positioning mapping options widget for root input,output mappings#511
axewilledge merged 3 commits intowso2:mainfrom
madushajg:idm

Conversation

@madushajg
Copy link
Member

@madushajg madushajg requested review from KCSAbeywickrama, axewilledge, Copilot and sachiniSam and removed request for gigara and hevayo September 19, 2025 08:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes positioning issues for mapping options widgets in data mapper diagrams by implementing boundary constraints to keep labels fully visible within the canvas area.

  • Adds canvas boundary detection to prevent labels from being positioned outside the visible area
  • Implements constraint logic to adjust label positions when they would exceed canvas boundaries
  • Applies the same fix to both Ballerina and MI data mapper components

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
workspaces/mi/mi-data-mapper/src/components/Diagram/OverriddenLinkLayer/LabelWidget.tsx Adds boundary constraint logic to keep mapping option labels within canvas bounds
workspaces/ballerina/data-mapper/src/components/Diagram/OverriddenLinkLayer/LabelWidget.tsx Identical boundary constraint implementation for Ballerina data mapper
Comments suppressed due to low confidence (2)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@axewilledge axewilledge reopened this Sep 19, 2025
@axewilledge axewilledge merged commit baac1f3 into wso2:main Sep 19, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants