[BI & MI Data Mappers] Fix positioning mapping options widget for root input,output mappings#511
Merged
axewilledge merged 3 commits intowso2:mainfrom Sep 19, 2025
Merged
Conversation
…lWidget to ensure labels remain fully visible within the canvas.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes positioning issues for mapping options widgets in data mapper diagrams by implementing boundary constraints to keep labels fully visible within the canvas area.
- Adds canvas boundary detection to prevent labels from being positioned outside the visible area
- Implements constraint logic to adjust label positions when they would exceed canvas boundaries
- Applies the same fix to both Ballerina and MI data mapper components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| workspaces/mi/mi-data-mapper/src/components/Diagram/OverriddenLinkLayer/LabelWidget.tsx | Adds boundary constraint logic to keep mapping option labels within canvas bounds |
| workspaces/ballerina/data-mapper/src/components/Diagram/OverriddenLinkLayer/LabelWidget.tsx | Identical boundary constraint implementation for Ballerina data mapper |
Comments suppressed due to low confidence (2)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
workspaces/mi/mi-data-mapper/src/components/Diagram/OverriddenLinkLayer/LabelWidget.tsx
Show resolved
Hide resolved
workspaces/mi/mi-data-mapper/src/components/Diagram/OverriddenLinkLayer/LabelWidget.tsx
Show resolved
Hide resolved
axewilledge
approved these changes
Sep 19, 2025
sachiniSam
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: wso2/product-ballerina-integrator#1329