refactor: qualify baseDelay in error message#9
Merged
maxence2997 merged 2 commits intomainfrom Mar 22, 2026
Merged
Conversation
1.Message said baseDelay without prefix → changed to autoReconnect.baseDelay
github-actions
bot
added
the
refactor
There was a problem hiding this comment.
Pull request overview
This PR refines a validateConfig error message in WspulseClient to fully qualify baseDelay as autoReconnect.baseDelay, aligning it with other qualified config validation messages (e.g., heartbeat fields).
Changes:
- Update the
autoReconnect.maxDelay >= autoReconnect.baseDelayvalidation error message to include the full field path.
1.MAX_MAX_DELAY/MAX_MAX_RETRIES hard to read → MAX_DELAY_LIMIT/MAX_RETRIES_LIMIT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoReconnect.maxDelay must be >= baseDelay→autoReconnect.maxDelay must be >= autoReconnect.baseDelayTest plan
make checkpasses