Fix bug reclvl file parser to account for ragged columns#302
Merged
Conversation
wtbarnes
added
I/O
bugfix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 92.70% 93.17% +0.46%
==========================================
Files 37 37
Lines 3111 3119 +8
==========================================
+ Hits 2884 2906 +22
+ Misses 227 213 -14 ☔ View full report in Codecov by Sentry. |
meeseeksmachine
pushed a commit
to meeseeksmachine/fiasco
that referenced
this pull request
Sep 10, 2024
wtbarnes
added a commit
that referenced
this pull request
Sep 10, 2024
…lumns (#303) Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for the reclvl parser to account for possible ragged columns. In some versions of the database, a given file may have rate and temperature arrays of unequal length. This deals with that case.