Skip to content

Use memmap=False instead of copy_arrays=False when opening asdf files#339

Merged
wtbarnes merged 2 commits intomainfrom
asdf-bugfix
Dec 9, 2024
Merged

Use memmap=False instead of copy_arrays=False when opening asdf files#339
wtbarnes merged 2 commits intomainfrom
asdf-bugfix

Conversation

@wtbarnes
Copy link
Owner

@wtbarnes wtbarnes commented Dec 8, 2024

Fixes #338

@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (8b9ef1f) to head (b34cd19).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   90.55%   90.96%   +0.40%     
==========================================
  Files          41       41              
  Lines        3400     3399       -1     
==========================================
+ Hits         3079     3092      +13     
+ Misses        321      307      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wtbarnes wtbarnes merged commit f6188e8 into main Dec 9, 2024
@wtbarnes wtbarnes deleted the asdf-bugfix branch December 9, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asdf parsing broken after recent update to asdf package

1 participant