Implement dielectronic recombination suppression calculation#411
Merged
Implement dielectronic recombination suppression calculation#411
Conversation
Owner
Author
8efbd6b to
ad7b594
Compare
69352d1 to
15b242e
Compare
Owner
Author
Owner
Author
|
I've now just made this a private method and I'm going to add the docstring info for this feature to the dielectronic recombination rate in a future PR as the user interface for this functionality is going to be via the actual rate calculation. |
This was referenced Aug 27, 2025
Owner
Author
|
Thanks @pryoung. I did a comparison with your most recent changes and get very good agreement for all of the relevant isoelectronic sequences now,
There is a small offset in the Be-like sequence but its below 1% relative difference so I'm not that concerned,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Fixes #233
TODOs
Ion?Finish docstringDecide on how this gets integrated into actual DR calculation (could be left to another PR)More guidance from Ambiguity in implementation of dielectronic recombination suppression factors chianti-atomic/chianti-idl#17