Merged
Conversation
Updated shuttle location update method from just changing the location to a smooth animation between location updates.
added shuttle animations key
fixed typo
added shuttle animation getter
added shuttle animations setter
added shuttle animation user preference to loadPreferences().
added setter to update shuttle animations preference
Add shuttle animation state to MapsUIState with default value of true
Pass shuttle animation setting to VehicleMarker
Added aniimationsEnabled parameter to VehicleMarker
Modified location update logic to be conditionally animated based on user preference
imported MapsViewModel
Injected MapsViewModel into SettingScreen
Load map state into SettingsScreen for animation toggle
Added settings item component for toggling shuttle animations
Added shuttle animation toggle to settings screen
Added heading_degrees field to VehicleLocation model
Added shuttle rotation preference key
Added getter for shuttle rotation setting
Added setter for shuttle rotation setting
Added shuttleRotationEnabled to MapsUiState
Load shuttle rotation preference in MapsViewModel
Added setter for shuttle rotation preference
Passed shuttle rotation setting to VehicleMarker
Added rotationEnabled parameter to vehicleMarker
Extracted headingDegrees for shuttle marker rotation
Applied conditional rotation to shuttle markers based on setting
Imported MapsViewModel into developer menu
Loaded map state into developer menu for rotation toggle
Add shuttle rotation toggle to developer menu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #130
Implements shuttle animations between location updates as a toggleable setting. Also adds shuttle rotation based on heading direction as a developer setting for testing and future support for a top-down or 3D vehicle model.