Skip to content

Conversation

@krystian-panek-vmltech
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a "skip by extension" feature that allows Groovy extension scripts to conditionally skip execution runs. The changes replace the previous "locking" flag with a "skipped" flag in ExecutionContext and add special handling for health check executions to ensure they always run.

Key changes:

  • Added ability for extension scripts to mark executions as skipped via context.skipped = true
  • Health check executions now use a dedicated ID and bypass both locking and skip checks
  • Refactored ExecutionContext to replace locking flag with skipped flag

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ACME-300_extension.groovy Example extension demonstrating skip functionality based on even/odd minutes
HealthChecker.java Updated to use dedicated HEALTH_CHECK ID and removed explicit locking configuration
Executor.java Added skip check logic and converted locking flag to be derived from health check status
ExecutionId.java Added HEALTH_CHECK constant for identifying health check executions
ExecutionContext.java Renamed locking field/methods to skipped

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@krystian-panek-vmltech krystian-panek-vmltech merged commit ffe8799 into main Oct 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants