Skip to content

Conversation

@krystian-panek-vmltech
Copy link
Collaborator

fixes #167

image

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for displaying the next scheduled execution time for automatic scripts with cron schedules. The implementation fetches scheduled job information from the job manager and displays it in the UI alongside existing script execution data.

Key changes:

  • Added ScriptSchedule type to capture script path and next execution time
  • Extended script listing API to include schedule information
  • Updated UI to display next execution time with timezone-aware date formatting
  • Improved date explanation component to differentiate between past and future dates

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
ui.frontend/src/types/script.ts Added ScriptSchedule type definition
ui.frontend/src/types/main.ts Updated ScriptOutput to include schedules array
ui.frontend/src/components/ScriptAutomaticList.tsx Added "Next Execution" column and removed unused UserInfo import
ui.frontend/src/components/DateExplained.tsx Enhanced to show "This will be" for future dates vs "This was" for past dates
core/src/main/java/dev/vml/es/acm/core/servlet/output/ScriptListOutput.java Added schedules field to output model
core/src/main/java/dev/vml/es/acm/core/servlet/ScriptServlet.java Integrated schedule fetching into script listing logic
core/src/main/java/dev/vml/es/acm/core/script/ScriptScheduler.java Added findScriptSchedule method and exposed service
core/src/main/java/dev/vml/es/acm/core/script/ScriptSchedule.java New model class for script schedule data
core/src/main/java/dev/vml/es/acm/core/acl/authorizable/AclGroup.java Code formatting improvements (whitespace)
core/src/main/java/dev/vml/es/acm/core/acl/authorizable/AclAuthorizable.java Code formatting improvements (line breaks)
core/src/main/java/dev/vml/es/acm/core/acl/Acl.java Code formatting improvements (line breaks)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@krystian-panek-vmltech krystian-panek-vmltech merged commit 82ed02c into main Oct 29, 2025
1 check passed
@krystian-panek-vmltech krystian-panek-vmltech deleted the next-schedule-info branch October 29, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next schedule info

2 participants