Lazy template engine #253
Merged
Lazy template engine #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystian-panek-vmltech
requested review from
Copilot and
jakub-berlinski-wttech
jakub-berlinski-wttech
approved these changes
Oct 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TemplateFormatter class by replacing the reusable GStringTemplateEngine instance field with a method that creates a new instance on every call. This changes the template engine from being instantiated once per TemplateFormatter instance to being instantiated multiple times during template rendering operations.
- Removed the private
enginefield and constructor - Added a
getEngine()method that creates a newGStringTemplateEngineinstance on each invocation - Updated all method calls to use
getEngine()instead of theenginefield
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jakub-berlinski-wttech
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.