Abort race condition fix #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the execution abortion flow by treating the STOPPED status as a pending state rather than a final state.
- The core fix ensures that when aborting an execution, the UI continues polling until the execution reaches its final
ABORTEDstatus instead of prematurely stopping when it encounters the transientSTOPPEDstatus - Reduces the default test data size in an example Groovy script from 5 million to 10,000 users for more practical testing
- Adds VS Code workspace settings to exclude build directories from search
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ui.frontend/src/types/execution.ts | Adds STOPPED status to isExecutionPending function to fix race condition during execution abortion |
| ui.content.example/src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-203_output-csv.groovy | Reduces default user count from 5,000,000 to 10,000 for more reasonable example execution times |
| .vscode/settings.json | Configures search exclusions for build artifacts and dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.