Slider, range and color arguments #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for new argument types—slider, color, and range—to both the frontend and backend code. Key changes include updates to type definitions and helper functions in api.types.ts, the addition of new UI components for slider, color, and range arguments in CodeArgumentInput.tsx, and corresponding new snippet and Java classes for these argument types.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui.frontend/src/utils/api.types.ts | Updated ArgumentType and ArgumentValue unions with SLIDER, COLOR, and RANGE types and added type definitions and guards |
| ui.frontend/src/components/CodeArgumentInput.tsx | Added new Controller blocks for slider, color, and range arguments |
| ui.content/.../argument/*.yml | New snippets added for slider, color, and range arguments |
| core/src/main/java/com/vml/es/aem/acm/core/code/arg/*.java | Introduced new argument classes for slider, range, and color |
| core/src/main/java/com/vml/es/aem/acm/core/code/Arguments.java & ArgumentType.java | Extended APIs to support new argument types |
...ontent/src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/color.yml
Outdated
Show resolved
Hide resolved
...ontent/src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/range.yml
Outdated
Show resolved
Hide resolved
krystian-panek-vmltech
approved these changes
Apr 29, 2025
krystian-panek-vmltech
approved these changes
Apr 29, 2025
core/src/main/java/com/vml/es/aem/acm/core/code/arg/RangeArgument.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/vml/es/aem/acm/core/code/arg/SliderArgument.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/vml/es/aem/acm/core/code/ArgumentType.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/vml/es/aem/acm/core/code/arg/NumberArgument.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/vml/es/aem/acm/core/code/arg/NumberArgument.java
Outdated
Show resolved
Hide resolved
...ontent/src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/color.yml
Outdated
Show resolved
Hide resolved
...src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/integerRange.yml
Outdated
Show resolved
Hide resolved
...src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/integerRange.yml
Show resolved
Hide resolved
core/src/main/java/com/vml/es/aem/acm/core/code/arg/ColorArgument.java
Outdated
Show resolved
Hide resolved
krystian-panek-vmltech
requested changes
May 8, 2025
Collaborator
krystian-panek-vmltech
left a comment
krystian-panek-vmltech
left a comment
There was a problem hiding this comment.
please address comments
core/src/main/java/com/vml/es/aem/acm/core/code/arg/IntegerRangeArgument.java
Outdated
Show resolved
Hide resolved
...ontent/src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/color.yml
Outdated
Show resolved
Hide resolved
...tent/src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/decimal.yml
Outdated
Show resolved
Hide resolved
...src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/decimalRange.yml
Outdated
Show resolved
Hide resolved
| this.display = Display.SLIDER; | ||
| } | ||
|
|
||
| public void slider(BigDecimal min, BigDecimal max) { |
Collaborator
There was a problem hiding this comment.
will it work with ints, doubles, strings when passed from groovy?
Collaborator
Author
There was a problem hiding this comment.
nope, only decimals, but I think it's expected if we want type safety?
| @@ -1,10 +1,32 @@ | |||
| import { Checkbox, CheckboxGroup, DatePicker, Flex, Item, ListView, NumberField, Picker, Radio, RadioGroup, Switch, TextArea, TextField, View } from '@adobe/react-spectrum'; | |||
| import { | |||
Collaborator
There was a problem hiding this comment.
sh taskw develop:frontend:format
Collaborator
Author
There was a problem hiding this comment.
It's not formatting idk why
krystian-panek-vmltech
approved these changes
May 12, 2025
...src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/decimalRange.yml
Show resolved
Hide resolved
...src/main/content/jcr_root/conf/acm/settings/snippet/available/core/argument/integerRange.yml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.