[pull] master from php:master #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-8.1: Enable GHSA-9pqp-7h25-4f32.phpt on Windows
* PHP-8.2: Enable GHSA-9pqp-7h25-4f32.phpt on Windows
* PHP-8.3: Enable GHSA-9pqp-7h25-4f32.phpt on Windows
* PHP-8.4: Enable GHSA-9pqp-7h25-4f32.phpt on Windows
… to incorrect error handling There are two functions that can each fail in their own way. If the last function fails we have to remove the filter entry from the hash table, otherwise we risk a UAF. Note also that removing the entry from the table on failure will also free its memory. Closes GH-17038.
* PHP-8.3: Fix GH-17037: UAF in user filter when adding existing filter name due to incorrect error handling
* PHP-8.4: Fix GH-17037: UAF in user filter when adding existing filter name due to incorrect error handling
This reverts commit 7685fb0. The test fails at least for PHP-8.2+ on CI. Needs closer investigation.
* PHP-8.1: Revert "Enable GHSA-9pqp-7h25-4f32.phpt on Windows"
* PHP-8.2: Revert "Enable GHSA-9pqp-7h25-4f32.phpt on Windows"
* PHP-8.3: Revert "Enable GHSA-9pqp-7h25-4f32.phpt on Windows"
* PHP-8.4: Revert "Enable GHSA-9pqp-7h25-4f32.phpt on Windows"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )